feat(ffe-form-react): Add support for forwarding refs #440
Conversation
|
Hm, looks like some of the tests break (but only when running jest in ci-mode). I'm gonna look into it. :) |
|
Related to this: jestjs/jest#5441 |
|
Could you perhaps add some documentation and an example? |
In my mind, this is something that should "just work" out of the box - but I don't mind adding an example |
|
Well, yeah, but since we're not doing this for all our components it might be worth pointing out to someone that isn't familiar with the codebase that we're doing it for this one? |
BREAKING CHANGE: Requires react@^16.3 This commit adds support for forwarding refs to the `Input` and `TextArea` components, so consumers can handle focus programmatically.
selbekk
force-pushed
the
231-use-forwardRef-take-two
branch
from
43ad6fc
to
998af6c
Compare
|
There - similar examples for both textarea and input components are added - and I think I fixed the tests as well. #famouslastwords |
| @@ -6,7 +6,7 @@ Vi har tre varianter av inputfelt: | |||
| 2. inline | |||
| 3. text-like | |||
|
|
|||
| _Standard_ og _inline_ er mest relevant for utviklere. De ser helt like ut, men opprører seg annerledes i samspillet | |||
| _Standard_ og _inline_ er mest relevant for utviklere. De ser helt like ut, men oppfører seg annerledes i samspillet | |||
There was a problem hiding this comment.
keep funny spelling error or we riot!
|
Do you want to merge this at some point @antidecaf or @kwltrs ? Since it's a breaking change (at least on paper), I'd like an OK from at least one of you. |
BREAKING CHANGE: Requires react@^16.3
This commit adds support for forwarding refs to the
InputandTextAreacomponents, so consumers can handle focus programmatically.Since this is a bump in peer dependencies, this is per definition a breaking change - but it's a small and simple one to deal with for most consumers.
Fixes #231