Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template.create, Template.update, Template.delete #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

begedin
Copy link

@begedin begedin commented Jul 3, 2018

This PR adds support for Template.create, .update and .delete

To enable this support, while following existing conventions as much as I could, I also had to define %Template{} and %Template.Response{} structs.

This PR still doesn't add support for Template.get/retrieve or Template.list

Since Template.delete seems to be the first supported endpoint which returns a 200 with a blank map as the response body, I extended support for automated body results decoding by checking if the decoded body has a results key.

I'm aware that there's the decode_results option I could've used, but that seems only specific and not very clean. If it's preferable for me to use that, I can update the PR.

@ewandennis
Copy link
Contributor

Hey @begedin - thanks for the PR! Will review asap.

@joshsmith
Copy link

@ewandennis any progress on this at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants