Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page secondary actions should use the outline button variation and render icon centered #517

Closed
jonambas opened this issue Jun 30, 2020 · 0 comments · Fixed by #530
Closed

Page secondary actions should use the outline button variation and render icon centered #517

jonambas opened this issue Jun 30, 2020 · 0 comments · Fixed by #530
Assignees
@jonambas
Labels
bug

Comments

@jonambas
Copy link
Contributor

jonambas commented Jun 30, 2020 •
edited
Loading

🐛 Bug report

Current Behavior

A single secondary action renders an outlineBorder button, icon is not centered

Expected behavior

A single secondary action renders an outline button, and icon is centered

Reproducible example

Check https://matchbox-storybook.netlify.app/?path=/story/layout-page--with-only-one-secondary-action

Screen Shot 2020-07-02 at 5 47 55 PM
@jonambas jonambas added the bug label Jun 30, 2020
@jonambas jonambas changed the title Page secondary actions should use the outline button variation Page secondary actions should use the outline button variation and be a square Jul 2, 2020
@jonambas jonambas changed the title Page secondary actions should use the outline button variation and be a square Page secondary actions should use the outline button variation and render icon centered Jul 2, 2020
@jonambas jonambas self-assigned this Jul 10, 2020
@jonambas jonambas mentioned this issue Jul 10, 2020
Merged
2 tasks
jonambas added a commit that referenced this issue Jul 13, 2020
@jonambas
Resolve #517 - Page secondary actions now render correctly, Adjust Pa…
bb10cf6 
…ge responsive behavior (#530)

* Secondary action kebab is now centered and renders an outlineBorder button

* Single secondary action renders outlineBorder button

* Adjust Page responsive breakpoints

* Allow responsive arrays in 'left' popover prop

* Fix PropTypes.oneOfType error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonambas jonambas

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@jonambas