Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel component should accept data-id prop #624

Closed
nicklemmon opened this issue Sep 9, 2020 · 0 comments
Closed

Panel component should accept data-id prop #624

nicklemmon opened this issue Sep 9, 2020 · 0 comments

Comments

@nicklemmon
Copy link
Contributor

🚀 Feature request

Current Behavior

<Panel data-id="something"/> does not currently render to the DOM.

Desired Behavior

Ideally, passing a value via data-id would render to the outer Panel element, allowing for chunking of sections of a page in Cypress.

Suggested Solution

Make sure this prop is being passed for nearly all components in Matchbox.

Who does this impact? Who is this for?

FE engineers for testing, product folks when it comes to targeting elements via Segment and other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant