Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-749 Generate JS token files #1028

Merged
merged 3 commits into from
Nov 30, 2021
Merged

UX-749 Generate JS token files #1028

merged 3 commits into from
Nov 30, 2021

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Nov 30, 2021

What Changed

  • Generates two javascript exports
    • tokens.legacy.js - Existing naming convention eg borderWidth_200
    • tokens.js - NEW snake-case only names

How To Test or Verify

  • Run npm run build inside the design-tokens-sd package
  • Verify the javascript exports are generated correctly

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonambas jonambas merged commit 2e0b14d into sd Nov 30, 2021
@jonambas jonambas deleted the UX-749 branch November 30, 2021 18:41
jonambas added a commit that referenced this pull request Dec 6, 2021
* UX-747 & UX-748: Add Style Dictionary and CSS custom properties file (#1026)

* UX-747 Add Style Dictionary basic setup

* UX-747 Add box-shadow

* UX-747 Update to a temporary package name

* UX-747 Update readme.md

* UX-747 Fix spelling error

* UX-750 Add SCSS map and function generation (#1027)

* UX-750 Add SCSS map and function generation

* UX-750 Interpolate string so quotes are not needed by end user

* UX-750 Fix font size tokens

* UX-749 Generate JS token files (#1028)

* UX-749 Generate JS token files

* UX-749 Update deprecated token file name

* UX-749 Use 'legacy' instead of 'deprecated'

* UX-752 Generate meta token file (#1030)

* UX-752 Add meta file generation

* UX-752 Add index.js file entry point

* UX-752 Some clean up

* UX-752 More clean up

* UX-755 Harden design tokens (#1032)

* UX-755 Harden design tokens

* UX-755 Add sd package to lerna

* UX-754 Prepare design token package

* UX-754 Prepare design token package part 2

* UX-754 Update readme

* UX-754 Update snapshots

* UX-754 Fix color-white and color casing in tests

* UX-754 Fix color-white types
@jonambas jonambas mentioned this pull request Dec 13, 2021
2 tasks
jonambas added a commit that referenced this pull request Dec 13, 2021
* UX-747 & UX-748: Add Style Dictionary and CSS custom properties file (#1026)

* UX-747 Add Style Dictionary basic setup

* UX-747 Add box-shadow

* UX-747 Update to a temporary package name

* UX-747 Update readme.md

* UX-747 Fix spelling error

* UX-750 Add SCSS map and function generation (#1027)

* UX-750 Add SCSS map and function generation

* UX-750 Interpolate string so quotes are not needed by end user

* UX-750 Fix font size tokens

* UX-749 Generate JS token files (#1028)

* UX-749 Generate JS token files

* UX-749 Update deprecated token file name

* UX-749 Use 'legacy' instead of 'deprecated'

* UX-752 Generate meta token file (#1030)

* UX-752 Add meta file generation

* UX-752 Add index.js file entry point

* UX-752 Some clean up

* UX-752 More clean up

* UX-755 Harden design tokens (#1032)

* UX-755 Harden design tokens

* UX-755 Add sd package to lerna

* UX-754 Prepare design token package

* UX-754 Prepare design token package part 2

* UX-754 Update readme

* UX-754 Update snapshots

* UX-754 Fix color-white and color casing in tests

* UX-754 Fix color-white types
logansparlin added a commit that referenced this pull request Jan 3, 2022
* UX-732 Create new matchbox-css library (#1031)

* UX-732 Create new matchbox-css library

* UX-732 remove prettier

* UX-733 Create color utility classes (#1033)

* UX-754 Style Dictionary (#1029)

* UX-747 & UX-748: Add Style Dictionary and CSS custom properties file (#1026)

* UX-747 Add Style Dictionary basic setup

* UX-747 Add box-shadow

* UX-747 Update to a temporary package name

* UX-747 Update readme.md

* UX-747 Fix spelling error

* UX-750 Add SCSS map and function generation (#1027)

* UX-750 Add SCSS map and function generation

* UX-750 Interpolate string so quotes are not needed by end user

* UX-750 Fix font size tokens

* UX-749 Generate JS token files (#1028)

* UX-749 Generate JS token files

* UX-749 Update deprecated token file name

* UX-749 Use 'legacy' instead of 'deprecated'

* UX-752 Generate meta token file (#1030)

* UX-752 Add meta file generation

* UX-752 Add index.js file entry point

* UX-752 Some clean up

* UX-752 More clean up

* UX-755 Harden design tokens (#1032)

* UX-755 Harden design tokens

* UX-755 Add sd package to lerna

* UX-754 Prepare design token package

* UX-754 Prepare design token package part 2

* UX-754 Update readme

* UX-754 Update snapshots

* UX-754 Fix color-white and color casing in tests

* UX-754 Fix color-white types

* UX-735 Add spacing & sizing tokens to utility library (#1034)

* UX-735 add spacing / sizing tokens and use new token structure

* Add matchbox-css to lerna.json

* UX-734, UX-736, UX-737, UX-738, UX-739, UX-740, UX-741 Create design token utility classes (#1035)

* UX-756 matchbox-css cleanup and tests (#1040)

* UX-756 CSS Library Cleanup & Tests

* UX-756 add CSS spec

* UX-756 remove snapshot

* UX-756 update CSS spec file to fix bugs

* Add Readme.md for matchbox-css library

* Add Readme.md for matchbox-css library

Co-authored-by: Jon Ambas <jon@jonambas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants