Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-744 Deprecate breadcrumbAction #1037

Merged
merged 2 commits into from
Dec 14, 2021
Merged

UX-744 Deprecate breadcrumbAction #1037

merged 2 commits into from
Dec 14, 2021

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Dec 13, 2021 •
edited
Loading

What Changed

  • Deprecates the breadcrumbAction prop on Page

How To Test or Verify

  • Visit a story using the prop in your code editor
  • Ensure the prop is marked as deprecated by the code editor

Screen Shot 2021-12-13 at 11 36 04 AM

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

logansparlin
logansparlin approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jonambas jonambas merged commit ffff196 into main Dec 14, 2021
@jonambas jonambas deleted the UX-744 branch December 14, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonambas @logansparlin