UX-777 Add small radio card variant #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logansparlin
approved these changes
Mar 1, 2022
| fontSize={fontSize} | ||
| lineHeight="400" | ||
| fontWeight="semibold" | ||
| fontSize={isSmall ? '200' : fontSize} |
There was a problem hiding this comment.
Maybe we rethink how fontSize is being defined, having '200' | fontSize is confusing
There was a problem hiding this comment.
@logansparlin Do you think I should just remove the weight prop? We don't use it anywhere in the app, its not in the figma component, and not entirely sure why we set it up like this
There was a problem hiding this comment.
Yea that's a good call
approved
jonambas
added a commit
that referenced
this pull request
Mar 8, 2022
* UX-777 Add small radio card variant * UX-777 Use size instead of variant * UX-777 Some cleanup * UX-777 Fix default size * UX-777 Clean up header font size * UX-777 Some cleanup * UX-777 Remove weight prop * UX-777 Remove weight prop from regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
sizeprop toRadioCardwhich acceptssmallspaceprop to RadioCard.Groupwhich acceptscompact`How To Test or Verify
PR Checklist
typelabel