Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 283 - Fix vertical alignment of tag close button #284

Merged
merged 3 commits into from
Nov 25, 2019
Merged

Resolve 283 - Fix vertical alignment of tag close button #284

merged 3 commits into from
Nov 25, 2019

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Nov 25, 2019 •
edited
Loading

Resolves #283

What Changed

  • Fixes vertical alignment on the Tag close button

Screen Shot 2019-11-25 at 10 37 54 AM

How To Test or Verify

PR Checklist

  • Add your changes to unreleased.md in the root directory. If you plan on publishing immediately after merging (such as a hotfix) or aren't making changes to a published package, you can ignore this step.
  • Provide screenshots or screen recordings for any visual changes.
  • Get approval from a UX team member (#uxfe or #design-guild on Slack) for any visual changes.

@gfriedmansp gfriedmansp self-requested a review November 25, 2019 16:02
gfriedmansp
gfriedmansp approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@gfriedmansp gfriedmansp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tested in app /w same changes for Tag with and without the close button.

@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.146%
Totals Coverage Status
Change from base Build 1092: 0.0%
Covered Lines: 545
Relevant Lines: 580
💛 - Coveralls

@jonambas jonambas merged commit 66c1603 into master Nov 25, 2019
@jonambas jonambas deleted the issue-283 branch November 25, 2019 18:07
@bkemper bkemper mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfriedmansp gfriedmansp gfriedmansp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag's close button is not aligned correctly
3 participants
@jonambas @coveralls @gfriedmansp