Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #529 - className is now accepted by Panel.Section #531

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Jul 10, 2020

Closes #529

What Changed

  • Passes className to Panel.Section

How To Test or Verify

  • Run storybook and visit the Panel story with multiple sections
  • Verify the className is in the DOM

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas changed the title Resolves #529 - className is now accepted by Panel.Section Resolve #529 - className is now accepted by Panel.Section Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #531 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         118      118           
  Lines        1560     1560           
=======================================
  Hits         1455     1455           
  Misses        105      105           
Impacted Files Coverage Δ
packages/matchbox/src/components/Panel/Section.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae9c76...93c9cb1. Read the comment docs.

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonambas jonambas merged commit fdada90 into main Jul 10, 2020
@jonambas jonambas deleted the issue-529 branch July 10, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Panel.Section component should accept the className prop
2 participants