UX-284 Darken button hover background colors #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 118 118
Lines 1568 1568
=======================================
Hits 1463 1463
Misses 105 105
Continue to review full report at Codecov.
|
| lightHoverColor = tokens.color_gray_100; | ||
| color = props.theme.colors.gray['900']; | ||
| darkHoverColor = props.theme.colors.gray['1000']; | ||
| lightActiveColor = props.theme.colors.gray['400']; |
There was a problem hiding this comment.
Do blue and red also need to be 2 steps darker than they were before?
There was a problem hiding this comment.
I kind of just eyeballed it, it seemed a little too light at first. What do you think?
There was a problem hiding this comment.
I think they're good how they are
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
outlineoutlineBorderandflatbuttonsHow To Test or Verify
PR Checklist
typelabel