Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-279 Export all styled-component helpers #565

Merged
merged 2 commits into from
Jul 29, 2020
Merged

UX-279 Export all styled-component helpers #565

merged 2 commits into from
Jul 29, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Jul 27, 2020

Notes
  • Ticket notes only to export the focusOutline helper, but thought it would be a good idea to export all of them
  • There are some changes included with the modifier parameter, these were initially made in UX-226 Add RadioCard and RadioCard.Group components #554 and are merged into rc/4.1.0. This just promotes it up to 4.0.x.

What Changed

  • Exports all styled-component helpers, under a styles object

How To Test or Verify

  • Visit the stories under Utility/StyleHelpers

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #565 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         118      118           
  Lines        1568     1568           
=======================================
  Hits         1463     1463           
  Misses        105      105           
Impacted Files Coverage Δ
...ackages/matchbox/src/components/ComboBox/styles.js 100.00% <ø> (ø)
packages/matchbox/src/components/Select/Select.js 96.77% <ø> (ø)
...ges/matchbox/src/components/TextField/TextField.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32ceee...6df9956. Read the comment docs.

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this is a draft, I'll re review once you wrap it up

@jonambas jonambas marked this pull request as ready for review July 29, 2020 17:22
@jonambas jonambas changed the title WIP Export all styled-component helpers UX-279 Export all styled-component helpers Jul 29, 2020
@jonambas jonambas merged commit e630a9f into main Jul 29, 2020
@jonambas jonambas deleted the UX-279 branch July 29, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants