Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-263 Adds Button variant prop #573

Merged
merged 6 commits into from
Aug 5, 2020
Merged

UX-263 Adds Button variant prop #573

merged 6 commits into from
Aug 5, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Aug 3, 2020

What Changed

  • Adds a new variant prop to Button
  • Deprecates the old props outline outlineBorder flat
  • Updates the components, and playroom snippets, that used the old props
    • Will update the site in another ticket

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas changed the base branch from main to rc/4.1.0 August 3, 2020 20:36
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #573 into rc/4.1.0 will increase coverage by 0.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc/4.1.0     #573      +/-   ##
============================================
+ Coverage     93.36%   93.38%   +0.01%     
============================================
  Files           128      128              
  Lines          1688     1692       +4     
============================================
+ Hits           1576     1580       +4     
  Misses          112      112              
Impacted Files Coverage Δ
...kages/matchbox/src/components/DatePicker/Navbar.js 100.00% <ø> (ø)
packages/matchbox/src/components/Drawer/Header.js 100.00% <ø> (ø)
packages/matchbox/src/components/Page/Page.js 89.65% <ø> (ø)
...s/matchbox/src/components/Pagination/Pagination.js 94.87% <0.00%> (ø)
packages/matchbox/src/components/Tabs/Tabs.js 88.57% <ø> (ø)
packages/matchbox/src/components/Button/Button.js 100.00% <100.00%> (ø)
packages/matchbox/src/components/Button/styles.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5ce4e...e035c19. Read the comment docs.

@jonambas jonambas marked this pull request as ready for review August 4, 2020 13:27
@jonambas jonambas changed the title Wip UX-263 Adds Button variant prop Aug 4, 2020
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonambas jonambas merged commit d6273ee into rc/4.1.0 Aug 5, 2020
@jonambas jonambas deleted the UX-263 branch August 5, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants