UX-286 Add indeterminate checkbox support #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 93.39% 93.66% +0.26%
==========================================
Files 118 138 +20
Lines 1574 1783 +209
==========================================
+ Hits 1470 1670 +200
- Misses 104 113 +9
Continue to review full report at Codecov.
|
logansparlin
approved these changes
Aug 14, 2020
| /** | ||
| * 'indeterminate' does not work with defaultChecked | ||
| */ | ||
| defaultChecked: PropTypes.oneOf([true, false]), |
There was a problem hiding this comment.
Any reason to do this instead of PropTypes.bool?
There was a problem hiding this comment.
Oh good catch haha
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
indeterminatechecked statedefaultCheckedprop doesn't work with intermediate, input must be fully controlledHow To Test or Verify
PR Checklist
typelabel