UX-224 Support composable ActionList components #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc/4.1.0 #584 +/- ##
============================================
+ Coverage 93.62% 93.64% +0.01%
============================================
Files 135 138 +3
Lines 1757 1777 +20
============================================
+ Hits 1645 1664 +19
- Misses 112 113 +1
Continue to review full report at Codecov.
|
| <CheckBox size={20} /> | ||
| </Box> | ||
| )} | ||
| {helpText && ( |
There was a problem hiding this comment.
Should we use <HelpText /> here?
| as={is === 'button' ? 'button' : null} | ||
| type={is === 'button' ? 'button' : null} | ||
| isType={is} | ||
| {...(is === 'checkbox' |
There was a problem hiding this comment.
This is a little hard to read, but I get what it's doing so not a big deal
logansparlin
approved these changes
Aug 13, 2020
| </Box> | ||
| ); | ||
| }, [content, selected, helpText]); | ||
|
|
||
| const isAttributes = |
There was a problem hiding this comment.
Nice, this is much easier to read
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
ActionList.ActionandActionList.SectioncomponentsActionListHow To Test or Verify
PR Checklist
typelabel