Resolves #625 - Add support for the className prop for the Column component #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonambas
approved these changes
Sep 9, 2020
| @@ -46,6 +47,7 @@ Column.displayName = 'Column'; | |||
| Column.propTypes = { | |||
| children: PropTypes.node, | |||
| width: PropTypes.oneOfType([PropTypes.oneOf(['content']), PropTypes.number]), | |||
| className: PropTypes.string, | |||
There was a problem hiding this comment.
I think this works. For your use case you could expose display
import { display } from 'styled-system`;
import { createPropTypes } from '@styled-system/prop-types';
...
const { width, children, className, display } = props;
...
<StyledColumn display={display} />
...
Column.propTypes = {
...createPropTypes(display.propNames),
}There was a problem hiding this comment.
styled(Box) already includes display so no need to add it to the StyledColumn declaration
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #625
What Changed
classNameaccepted as a prop for the<Column/>componentHow To Test or Verify
PR Checklist