Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-322 Include Webp Image Formats #631

Merged
merged 1 commit into from
Sep 10, 2020
Merged

UX-322 Include Webp Image Formats #631

merged 1 commit into from
Sep 10, 2020

Conversation

logansparlin
Copy link
Contributor

@logansparlin logansparlin commented Sep 10, 2020 •
edited by jonambas
Loading

Closes #620

What Changed

  • Added .webp image formats for all images at all sizes in @sparkpost/matchbox-media

How To Test or Verify

  • npm run start:storybook
  • verify images stories

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas
Copy link
Contributor

Closes #620

jonambas
jonambas approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jonambas jonambas merged commit ed1b55a into main Sep 10, 2020
@jonambas jonambas deleted the UX-322 branch September 10, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonambas jonambas jonambas approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sparkpost/matchbox-media package should provide .webp image formats
2 participants
@logansparlin @jonambas