Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-223 Add Picture Component #637

Merged
merged 2 commits into from
Sep 23, 2020
Merged

UX-223 Add Picture Component #637

merged 2 commits into from
Sep 23, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Sep 14, 2020

What Changed

  • Adds new Picture and Picture.Image components

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just one small comment

return (
<StyledFigure
as="figure"
m="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to set this since we're using margin system props too? Could just be a default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm I see what this is doing

@jonambas jonambas changed the base branch from main to rc/4.4.0 September 22, 2020 17:20
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

return (
<StyledFigure
as="figure"
m="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm I see what this is doing

@jonambas jonambas merged commit b653b02 into rc/4.4.0 Sep 23, 2020
@jonambas jonambas deleted the UX-223 branch September 23, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants