Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-334 Support grid orientation & Allow non RadioCard children #640

Merged
merged 6 commits into from
Sep 18, 2020
Merged

UX-334 Support grid orientation & Allow non RadioCard children #640

merged 6 commits into from
Sep 18, 2020

Conversation

jonambas
Copy link
Contributor

Closes #629

What Changed

  • Adds new grid orientation option
  • Removes restriction on React children inside radio card groups

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

logansparlin
logansparlin approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonambas jonambas merged commit 0da19d2 into main Sep 18, 2020
@jonambas jonambas deleted the UX-334 branch September 18, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RadioCard.Group to allow passing other children
2 participants
@jonambas @logansparlin