Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-342 Support prop on Modal.Content #647

Merged
merged 1 commit into from
Sep 23, 2020
Merged

UX-342 Support prop on Modal.Content #647

merged 1 commit into from
Sep 23, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Sep 22, 2020 •
edited
Loading

What Changed

  • Removes modal content default prop p
  • Hardcodes the default instead so padding works when passed to the component

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

logansparlin
logansparlin approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonambas jonambas merged commit 2614738 into main Sep 23, 2020
@jonambas jonambas deleted the UX-342 branch September 23, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonambas @logansparlin