Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-352 Add white button color #672

Merged
merged 4 commits into from
Oct 27, 2020
Merged

UX-352 Add white button color #672

merged 4 commits into from
Oct 27, 2020

Conversation

logansparlin
Copy link
Contributor

What Changed

  • Added white button color

How To Test or Verify

  • npm run start:storybook
  • Verify button stories

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas self-requested a review October 23, 2020 17:03
jonambas
jonambas suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other comment

Also

props.buttonVariant == 'mutedOutline' ? theme.colors.gray[400] : color

400 here for mutedOutline doesnt feel different enough from the regular outline version. Maybe try a darker gray to make the borders more subtle?

packages/matchbox/src/components/Button/styles.js Outdated Show resolved Hide resolved
jonambas
jonambas approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@logansparlin logansparlin merged commit 2e1f465 into main Oct 27, 2020
@jonambas jonambas deleted the UX-352 branch February 18, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonambas jonambas jonambas approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logansparlin @jonambas