Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-360 use Warning icon for banner warning status icon #677

Merged
merged 4 commits into from
Nov 6, 2020
Merged

UX-360 use Warning icon for banner warning status icon #677

merged 4 commits into from
Nov 6, 2020

Conversation

logansparlin
Copy link
Contributor

@logansparlin logansparlin commented Oct 29, 2020 •
edited by jonambas
Loading

Closes #239

What Changed

  • Use Warning icon for warning banner status icon

How To Test or Verify

  • npm run start:storybook
  • Verify banner stories

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas self-requested a review November 5, 2020 23:42
jonambas
jonambas approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonambas
Copy link
Contributor

jonambas commented Nov 6, 2020

Closes #239

@logansparlin logansparlin merged commit 3f456cf into main Nov 6, 2020
@jonambas jonambas deleted the UX-360 branch February 18, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonambas jonambas jonambas approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some differences between Banner component states are communicated through color alone
2 participants
@logansparlin @jonambas