UX-367 Fix ListBox key events bug #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logansparlin
force-pushed
the
UX-367
branch
3 times, most recently
from
8b370f4 to
5bb3df1
Compare
jonambas
approved these changes
Nov 9, 2020
| const index = options.findIndex(option => | ||
| option.props.value.toLowerCase().startsWith(keysSoFar), | ||
| option.props.children.toLowerCase().startsWith(keysSoFar), |
There was a problem hiding this comment.
Just to clarify, this is searching children (the option label) instead of the value, right?
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
ListBox.Optionthrows an errorstart:localMatchboxscript to the site to make testing matchbox changes in the design site easierHow To Test or Verify
npm run start:storybookPR Checklist
typelabel