Skip to content

ESCSP-5547 sink #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022
Merged

ESCSP-5547 sink #672

merged 3 commits into from
Apr 19, 2022

Conversation

tuck1s
Copy link
Contributor

@tuck1s tuck1s commented Apr 19, 2022

  • Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue Create new-pricing-increases-costs #123: Fix bug in component"
  • Your PR title will be visible in changelogs

What Changed

  • What changes does this PR propose?
  • Provide screenshots or screen recordings for any visual changes.

How To Test or Verify

  • Describe any steps that may help reviewers verify changes.
  • Anything beyond basic unit testing, such as assistive tech usage, or special interactions.

PR Checklist

Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.

For example: If you are submitting a content change to one of the support documents, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Content Changes Checklist

If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Development Changes Checklist"

All PRs Checklist

  • Give your pull request a meaningful name.
  • Use lowercase filenames.
  • Apply at least one team label according to which team is the content expert (ie. team-FE or team-SAZ)
  • Pull request approval from the FE team or content experts (see label applied above) that isn't the content creator.

Content Changes Checklist

  • Check that your article looks correct in the preview here or in a Netlify deploy preview.
  • Check the links in your article.
  • Check the images in your article (if there are any)
  • Check to make sure you are using markdown appropriately as outlined in examples/article.md in the root of the project directory and on the momentum doc's preface article
  • Check to make sure the Copy and Tone Guidelines are followed.

Development Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")

  • The appropriate tests are created in cypress/ directory in the root of the project
  • The lighthouse score is passing according to the FE Support Docs' Service Outline SLI/SLOs

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for support-docs ready!

Name Link
🔨 Latest commit a83a15f
🔍 Latest deploy log https://app.netlify.com/sites/support-docs/deploys/625ee3657de5dc0009580835
😎 Deploy Preview https://deploy-preview-672--support-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tuck1s tuck1s changed the title Escsp 5547 sink ESCSP-5547 sink Apr 19, 2022
1. append the email addresses you are injecting into our system with `*.sink.sparkpostmail.com`. Please note, the asterisk (`*`) is a wildcard, where you will place the domain portion of your injected email address.
2. You also need to prefix the campaign_id you are injecting into our system with `sparkpost-performance-test-*`. Please note, the asterisk (`*`) is a wildcard, where you will place anything as part of the campaign_id.
1. append the email addresses you are injecting into our system with `*.sink.sparkpostmail.com`. Please note, the asterisk (`*`) is a wildcard, where you will place the domain portion of your injected email address.
2. For high capacity performance testing, we recommend to disable populating your account Events reporting (API and UI) with the sink delivery events. Prefix the campaign_id you are injecting into our system with `sparkpost-performance-test-*`. Please note, the asterisk (`*`) is a wildcard, where you will place anything as part of the campaign_id. Webhooks event reporting will still occur.
Copy link

@mvanbosch mvanbosch Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mention metrics/Signals Analytics reporting will work as well

@tuck1s tuck1s merged commit 2488e01 into main Apr 19, 2022
@tuck1s tuck1s deleted the ESCSP-5547-sink branch April 19, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants