Skip to content

TR-4678 Update guides on setting up HTTPS ET #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

TR-4678 Update guides on setting up HTTPS ET #752

merged 1 commit into from
Oct 5, 2023

Conversation

mtgray-sp
Copy link
Contributor

@mtgray-sp mtgray-sp commented Sep 30, 2023

What Changed

  • Updated the Apache and NGINX guides
    • Updated the sample configuration files
  • Updated the AWS CloudFront guide
    • Added a step about sending the X-Forwarded-Host header to the origin
    • Removed the step about forwarding the Host header to the origin
    • Added a step about forwarding the target query parameter to the origin
    • Updated screenshots

How To Test or Verify

  • Set up HTTPS ET by following the updated guides

PR Checklist

Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.

For example: If you are submitting a content change to one of the support documents, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Content Changes Checklist

If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Development Changes Checklist"

All PRs Checklist

  • Give your pull request a meaningful name.
  • Use lowercase filenames.
  • Apply at least one team label according to which team is the content expert (ie. team-FE or team-SAZ)
  • Pull request approval from the FE team or content experts (see label applied above) that isn't the content creator.

Content Changes Checklist

  • Check that your article looks correct in the preview here or in a Netlify deploy preview.
  • Check the links in your article.
  • Check the images in your article (if there are any)
  • Check to make sure you are using markdown appropriately as outlined in examples/article.md in the root of the project directory and on the momentum doc's preface article
  • Check to make sure the Copy and Tone Guidelines are followed.

Development Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")

  • The appropriate tests are created in cypress/ directory in the root of the project
  • The lighthouse score is passing according to the FE Support Docs' Service Outline SLI/SLOs

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for support-docs ready!

Name Link
🔨 Latest commit 288a123
🔍 Latest deploy log https://app.netlify.com/sites/support-docs/deploys/651a10369966b500087a54c0
😎 Deploy Preview https://deploy-preview-752--support-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtgray-sp mtgray-sp added the team - TR Transmissions team is the subject matter expert and need to approve this PR label Sep 30, 2023
@mtgray-sp mtgray-sp force-pushed the TR-4678 branch 6 times, most recently from c72e56d to 3a4ec38 Compare October 1, 2023 21:38
Copy link
Member

@gilesv gilesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to set up HTTPs for my tracking domain in EU using CloudFront.

I have also successfully set up two reverse proxies running on EC2 (one with Apache and another with Nginx), to forward requests from my tracking domain to eu.spgo.io. The additional configuration to avoid DNS caching issues (resolver for nginx and disablereuse for apache) is valid. HTTPs was very easy to set up with certbot. Also verified that link spoofing didn’t work.

I noticed that Apache didn’t need a directive to forward the correct Host header, its default behavior works well for tracking links.

LGTM

@mtgray-sp mtgray-sp merged commit 1cc6035 into main Oct 5, 2023
@mtgray-sp mtgray-sp deleted the TR-4678 branch October 5, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:shipit: approved team - TR Transmissions team is the subject matter expert and need to approve this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants