Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpoolWriter no longer using System.Configuration or System.Web.Configuration #70

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

bounav
Copy link
Collaborator

@bounav bounav commented Sep 26, 2022

  • The spool writer is encoding agnostic (it send the string as to the spool page that in turns just grabs the string's bytes)
  • Encoding has to be overridden on TextWriter which SpoolWriter inherits from; now the property throws a new NotSupportedException()
  • Added a unit test to illustrate the behaviour

…from SpoolWriter

- The spool writer is encoding agnostic (it send the string as to the spool page that in turns just grabs the string's bytes)
- Encoding has to be overriden on TextWriter so now the property throws a NotSupportedException()
- Added a unit test to illustrate the behaviour
@bounav
Copy link
Collaborator Author

bounav commented Sep 26, 2022

This is one small step towards a System.Web free Spark.

@bounav bounav merged commit 666b33a into master Sep 29, 2022
@bounav bounav deleted the spoolwriter-encoding branch September 29, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants