bugfix: impose no message size limit, use same version of PAKE in sender and receiver #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sender and receiver had different versions of schollz/pake. The old version in the receiver was broken in go 1.19 (golang/go#50974) - Upgrade other packages -
Codecov ReportBase: 25.00% // Head: 36.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
===========================================
+ Coverage 25.00% 36.20% +11.20%
===========================================
Files 5 5
Lines 172 174 +2
===========================================
+ Hits 43 63 +20
+ Misses 113 88 -25
- Partials 16 23 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Dev -> Master)
Remove message size limitations. This broke portal for larger files than 32KB since the latest release which uses the nhooyr/websocket library.
Sender and receiver had different versions of schollz/pake. The old
version in the receiver was broken in go 1.19.
(crypto/elliptic: IsOnCurve returns true for invalid field elements golang/go#50974)
Upgrade other packages.