feat: file summary table #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- finished state for receiver shows **all** received files in the table - finished state for both sender and receiver removes selection of cell - styling of file table adjusted to Portal's orange color theme
Codecov ReportBase: 25.00% // Head: 28.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34 +/- ##
===========================================
+ Coverage 25.00% 28.91% +3.91%
===========================================
Files 5 6 +1
Lines 172 249 +77
===========================================
+ Hits 43 72 +29
- Misses 113 157 +44
- Partials 16 20 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mellonnen
reviewed
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a summary of sent/received files are shown during/after transfer
for the sender, the summary shows up to 4 rows at a time and can be scrolled with
uparrow/kanddownarrow/jfor the receiver, the summary can only be shown after transfer and is therefore expanded to show all rows (all received files) before exiting the program
finished state for both sender and receiver removes cell selection styling and shows all sent/received files in uncolored plaintext