Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor config for more extensibility #51

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

ZinoKader
Copy link
Member

@ZinoKader ZinoKader commented Feb 23, 2023

  • config YAML is built from a Config struct
  • moved config-related things to its own package

@ZinoKader ZinoKader requested a review from mellonnen February 23, 2023 15:25
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #51 (2ed0248) into develop (11a72a8) will increase coverage by 8.69%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
+ Coverage    31.30%   40.00%   +8.69%     
===========================================
  Files            6        6              
  Lines          230      230              
===========================================
+ Hits            72       92      +20     
+ Misses         138      111      -27     
- Partials        20       27       +7     
Impacted Files Coverage Δ
portal/portal.go 36.11% <0.00%> (+36.11%) ⬆️
portal/config.go 100.00% <0.00%> (+100.00%) ⬆️

Impacted file tree graph

Copy link
Member

@mellonnen mellonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the config package belongs in the cmd/portal folder. And TBH the UI package should probably be in that folder as well

ui/sender/sender.go Show resolved Hide resolved
@mellonnen mellonnen merged commit 88805c3 into develop Feb 23, 2023
@ZinoKader ZinoKader deleted the f/refactor-config branch February 26, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants