Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip for step argument conversions to NullValueRetriever docs #2620

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

SeanKilleen
Copy link
Contributor

@SeanKilleen SeanKilleen commented Jul 18, 2022

Closes #2619.

Remaining Tasks

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory) (docs, not code)
  • I have added an entry to the changelog. (mandatory) (does not seem to apply here)
  • My change requires a change to the documentation. (well, it is a change to the documentation.)
  • I have updated the documentation accordingly.

@SeanKilleen SeanKilleen changed the title WIP: Add tip for step argument conversions to NullValueRetriever docs Add tip for step argument conversions to NullValueRetriever docs Jul 18, 2022
@SeanKilleen
Copy link
Contributor Author

SeanKilleen commented Jul 18, 2022

@SabotageAndi I think this covers the doc changes that would help with #2619 in the future. Ready for your review when you're able.

The ReadTheDocs preview failed, but I can't see why. I took my formatting from this ReadTheDocs Sphinx page but perhaps I did something wrong.

@SabotageAndi
Copy link
Contributor

@SeanKilleen looks like something changed on ReadTheDocs side. Suddenly some configuration is missing.
I will have a look at it.

@SeanKilleen
Copy link
Contributor Author

Great! Looks like it's passed now, though I don't have access to view it.

@SabotageAndi SabotageAndi merged commit b57dde1 into SpecFlowOSS:master Jul 21, 2022
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
…cFlowOSS#2620)

Co-authored-by: Andreas Willich <SabotageAndi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Register / use NullValueRetriever
2 participants