Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async transformations #2230 #2660

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Fix async transformations #2230 #2660

merged 5 commits into from
Oct 24, 2022

Conversation

gasparnagy
Copy link
Contributor

@gasparnagy gasparnagy commented Oct 24, 2022 •
edited
Loading

This PR fixes #2230 and allows using async step argument transformations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gasparnagy gasparnagy mentioned this pull request Oct 24, 2022
Merged
10 tasks
@gasparnagy gasparnagy marked this pull request as ready for review October 24, 2022 12:16
@gasparnagy
Copy link
Contributor Author

The #if NETFRAMEWORK conditions will be eliminated with #2661

@SabotageAndi SabotageAndi merged commit 4c3489e into master Oct 24, 2022
@SabotageAndi SabotageAndi deleted the fix_async_transformations_2230 branch October 24, 2022 12:31
clrudolphi pushed a commit to clrudolphi/SpecFlow that referenced this pull request Oct 24, 2022
@gasparnagy @clrudolphi
Fix async transformations SpecFlowOSS#2230 (SpecFlowOSS#2660)
39b2493
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
@gasparnagy @Code-Grump
Fix async transformations SpecFlowOSS#2230 (SpecFlowOSS#2660)
dcc7e2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabotageAndi SabotageAndi SabotageAndi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StepArgumentTransformation Async/Await support
2 participants
@gasparnagy @SabotageAndi