Fix for SF2649: Aggregate exceptions lost from async step definitions #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reserveStackTrace' replaced with call to ExceptionDispatchInfo.Capture. BindingInvoker unit tests added to validate handling of various combinations of exceptions thrown from sync and async StepDefinition methods.
…. BindingInvoker changed to pass AggregateExceptions through. Use of 'PreserveStackTrace' replaced with call to ExceptionDispatchInfo.Capture. BindingInvoker unit tests added to validate handling of various combinations of exceptions thrown from sync and async StepDefinition methods. TestExecutionEngine updated to also use ExceptionDispatchInfo.Capture().Throw() in order to preserve the stack trace of user-hook's exception.
…ttps://github.com/clrudolphi/SpecFlow into AggregateExceptions_lost_from_async_StepDefs_2649
gasparnagy
added a commit
that referenced
this pull request
Nov 9, 2022
* master: Report binding problems to binding registry and show them as errors during test execution (#2663) Fix for SF2649: Aggregate exceptions lost from async step definitions (#2667) # Conflicts: # TechTalk.SpecFlow/Bindings/BindingInvoker.cs # Tests/TechTalk.SpecFlow.RuntimeTests/Bindings/BindingInvokerTests.cs
Code-Grump
pushed a commit
to Code-Grump/SpecFlow
that referenced
this pull request
Mar 29, 2023
…SpecFlowOSS#2667) * BindingInvoker changed to pass AggregateExceptions through. Use of 'PreserveStackTrace' replaced with call to ExceptionDispatchInfo.Capture. BindingInvoker unit tests added to validate handling of various combinations of exceptions thrown from sync and async StepDefinition methods. * BindingInvoker now passes AggregateExceptions along up the call chain. BindingInvoker changed to pass AggregateExceptions through. Use of 'PreserveStackTrace' replaced with call to ExceptionDispatchInfo.Capture. BindingInvoker unit tests added to validate handling of various combinations of exceptions thrown from sync and async StepDefinition methods. TestExecutionEngine updated to also use ExceptionDispatchInfo.Capture().Throw() in order to preserve the stack trace of user-hook's exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist: