-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-4810: Vertical Nav #1106
base: stage/v7.0.0
Are you sure you want to change the base?
BED-4810: Vertical Nav #1106
Conversation
cmd/ui/tsconfig.json
Outdated
"include": [ | ||
"src" | ||
], | ||
"include": ["src", "../../packages/javascript/bh-shared-ui/src/components/AppIcon"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im curious what the added AppIcon
is used for? Was there a problem with local development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I saw that was added automatically and didn't really question it. I will dig into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like its not needed so i removed it. But will keep an eye on it.
packages/javascript/bh-shared-ui/src/components/Navigation/MainNav.tsx
Outdated
Show resolved
Hide resolved
packages/javascript/bh-shared-ui/src/components/Navigation/SubNav.tsx
Outdated
Show resolved
Hide resolved
Adding a reminder to point this PR to the |
The selected nav item background color in dark mode feels like it has too much contrast against the rest of the nav bar. This ends up making the color of the text not have enough contrast when hovered over. Light mode looks okay for this situation. These settings seemed nicer but they might not exactly align with the design system |
packages/javascript/bh-shared-ui/src/components/Navigation/MainNav.tsx
Outdated
Show resolved
Hide resolved
@urangel Good point, although maybe you need to pull latest because I had already pushed a possible fix for that, I figured to avoid the color contrast issue I would not apply hover color on active but still have the underline to have some feedback. See below and let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new nav looks nice! Good work with the expand collapse transitions and thanks for adding the icon creation notes.
Thanks man! but Icon creation notes was the work of @benwaples so kudos to him. I just moved it into bh-shared so we could use it in both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!!
Description
Replaces the top header with a side vertical nav in the left of the app. In this PR we have:
Motivation and Context
This PR addresses: BED-4810
How Has This Been Tested?
Manually and by adding tests.
Screenshots (optional):
Types of changes
Checklist: