Ingest GPOLocalGroup data #1147
Open
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While collected by SharpHound, the GPOChanges node of OUs was not taken into account to generate local group membership relations. For every affected computer, new ADLocalGroup nodes with corresponding LocalToComputer and MemberOfLocalGroup edges are generated. This should fix issue SpecterOps#280.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull requests ingests the
GPOChangesJSON object as collected by SharpHound'sGPOLocalGroupcollector and adds the required nodes for the local groups and corresponding edges for the membership relation.This in turn enables the existing analysis algorithm to create the previously missing
AdminTo,CanRDP,CanPSRemoteandExecuteDCOMedges for principals assigned to local groups by means of GPOs.Motivation and Context
This PR addresses GitHub issues #280 (and #240).
How Has This Been Tested?
Tested in a local Ludus lab instance.
Types of changes
Checklist: