Bed 5444 search type on tab change #1166
Open
+452
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly remove items found in updatedParams
benwaples
added
enhancement
urangel
reviewed
Feb 26, 2025
| @@ -0,0 +1,214 @@ | |||
| // Copyright 2023 Specter Ops, Inc. | |||
There was a problem hiding this comment.
nit: new files should reflect the year they were created for this license
There was a problem hiding this comment.
Woah nice catch! This is because I c/p from the OG file. Ill get this updated. Thanks!
urangel
reviewed
Feb 26, 2025
| @@ -0,0 +1,225 @@ | |||
| // Copyright 2023 Specter Ops, Inc. | |||
There was a problem hiding this comment.
nit: new files should reflect the year they were created for this license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets
searchTypeon tab change of explore search tab and sets the initial tab on first render if searchType is one of the 3 tabs.Motivation and Context
This PR addresses: BED-5444
Matches current functionality on tab change where we refetch the search of that tab. And allows for having the activeTab of the explore search tab header supported via deep linking.
How Has This Been Tested?
added unit tests and manual tests
Enable
deepLinkingbrowser mocks to test manuallyScreenshots (optional):
Types of changes
Checklist: