BED-5453: deep linking support for selected environment #1170
Conversation
…nly remove items found in updatedParams
| @@ -18,10 +18,13 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
these changes are to match bhe test-utils.jsx as much as possible. It main intention is adding support for testing customHooks with providers
| // limitations under the License. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
There was a problem hiding this comment.
directly ported from BHE
| @@ -15,7 +15,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Improves types and plumbs queryOptions thru useFeatureFlag (singular).
| environmentAggregation: EnvironmentAggregation | null; | ||
| }; | ||
|
|
||
| export const environmentAggregationMap = { |
There was a problem hiding this comment.
pull from and deduped bhe
| @@ -26,11 +25,7 @@ describe('SubNav', () => { | |||
| path: '/administration/test-nav-item-path', | |||
| }; | |||
|
|
|||
| render( | |||
| <BrowserRouter> | |||
There was a problem hiding this comment.
A Router is now in the set of default providers when using the test-utils render method
| @@ -69,6 +69,7 @@ | |||
| "eslint-config-prettier": "^9.1.0", | |||
| "eslint-plugin-react": "^7.34.1", | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "history": "^5.3.0", | |||
There was a problem hiding this comment.
same package added to bhe and bhce
| }, | ||
| })); | ||
|
|
||
| const QualityAssuranceV2: React.FC = () => { |
There was a problem hiding this comment.
I made a v2 for the QA component to consolidate the state in a similar way as GroupManagementContent because they behave similarly from a selected environment perspective.
Also added a loading state while fetching the environment
| @@ -14,7 +14,7 @@ | |||
| // | |||
There was a problem hiding this comment.
All changes in here are either renaming useAvailableDomains, or porting styles from the original GraphView
Description
Describe your changes in detail
Motivation and Context
This PR addresses: [GitHub issue or Jira ticket number]
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: