Bed-4851 OIDC API Provider Registration #894
Conversation
…teractions to match new design
mvlipka
added
work in progress
mvlipka
changed the title
mvlipka
removed
the
work in progress
cmd/api/src/database/oidc.go
Outdated
| return provider, CheckError(s.db.WithContext(ctx).Table("oidc_providers").Create(&provider)) | ||
| // Create both the sso_providers and oidc_providers rows in a single transaction | ||
| // If one of these requests errors, both changes will be rolled back | ||
| err := s.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error { |
There was a problem hiding this comment.
I'm not the BIGGEST fan of intermingling the CreateSSOProvider and CreateOIDCProvider methods since the end-user may simply want to just create an oidc_provider, for whatever reason. With our usecase, though, these tables are required to be in sync with each other so I felt comfortable doing this
…rly backfill saml_providers with the new sso_providers key. Added new enum type for sso_provider types
…ed a mapping from AuthProvider to the new SSOProviderType enum
There was a problem hiding this comment.
Did we want to also update the SAML create db op with a tx for creating SSO in this PR or wait for another one?
We still need to update the users table as well I think. Might be able to swap to sso_id vs 2 separate columns 🤔 That's likely worth a full separate PR
| if ssoProvider, err := bhdb.CreateSSOProvider(ctx, name, model.SessionAuthProviderOIDC); err != nil { | ||
| return err | ||
| } else { | ||
| oidcProvider.SSOProviderID = int(ssoProvider.ID) |
There was a problem hiding this comment.
Nit: With everything being serial, we shouldn't need the type assertion here.
There was a problem hiding this comment.
We still need the conversion since Serial is explicitly denoted as int32
Annoying, but I'd rather keep the int field for SSOProviderID
I was thinking another ticket, but there's no harm in throwing it in here as well while it's fresh in our minds |
mvlipka
added
the
work in progress
…. Removed enum and replaced with integer for the sso_provider type
Description
Modify the previously merged OIDC provider registration endpoint to support the new slug formatting, new sso_provider table, and move the URL to a new location to prevent collisions with existing endpoints.
Motivation and Context
After our syncs on 09/27 and 09/30, we decided to make some changes to the last PR in order to better support an agnostic API for both oidc & saml providers.
This PR addresses: BED-4766
How Has This Been Tested?
just bh-devto start up BHCE and ensure the migrations ranVerified a 201 response and that the data was inserted into the database with the correct formatting and referencing:
Screenshots (optional):
Types of changes
Checklist: