Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #108

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Small fixes #108

merged 4 commits into from
Jul 29, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

Identified some bugs in testing, fixing those. CommonLib bump + a log statement in the wrong spot

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit f17436e into 2.X Jul 29, 2024
1 check passed
@rvazarkar rvazarkar deleted the small_fixes branch July 29, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juggernot325 juggernot325 juggernot325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvazarkar @juggernot325