Add an option to disable LDAPS Certificate verification #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase against the most recent build |
|
Done |
|
Not sure why, but the build is still failing. I updated the CommonLib to include the new param, but its not showing up. |
|
I'm just going to go ahead and do the work myself and credit you. I'll close this MR afterwards. Thanks for the work! |
rvazarkar
added a commit
that referenced
this pull request
Jun 23, 2022
…for the work on the commonlib and the MR. #24
|
Hi @rvazarkar, Thanks for the commit ! |
|
Yep, its not needed since we're just passing it directly into the LDAPConfig, and we're not using it elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, DotNet (which SharpHound uses) perform strong verification of LDAPS TLS certificates.
This is unlike
bloodhound-pythonwhich does not verify SSL on its queries.DotNet TLS verification is notoriously tricky, and sometimes fail even trough the certificate is perfectly valid (For instance, because the CRL cannot be reached or because TLS 1.3 can't be used..). This can be a problem when running bloodhound in LDAPS-only environments.
This PR add an option to disable verification of the TLS certificate when doing LDAPS queries
(Related to SpecterOps/SharpHoundCommon#30)