chore: use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (#…

…1080)

core/models/delay.go

@@ -1,7 +1,6 @@
 package models
 
 import (
-	"errors"
 	"fmt"
 	"regexp"
 	"strings"
@@ -29,10 +28,10 @@ func ValidateResponseDelayPayload(j v1.ResponseDelayPayloadView) (err error) {
 		for _, delay := range j.Data {
 			if delay.UrlPattern != "" && delay.Delay != 0 {
 				if _, err := regexp.Compile(delay.UrlPattern); err != nil {
-					return errors.New(fmt.Sprintf("Response delay entry skipped due to invalid pattern : %s", delay.UrlPattern))
+					return fmt.Errorf("Response delay entry skipped due to invalid pattern : %s", delay.UrlPattern)
 				}
 			} else {
-				return errors.New(fmt.Sprintf("Config error - Missing values found in: %v", delay))
+				return fmt.Errorf("Config error - Missing values found in: %v", delay)
 			}
 		}
 	}

core/models/delay_log_normal.go

@@ -41,7 +41,7 @@ func ValidateResponseDelayLogNormalPayload(j v1.ResponseDelayLogNormalPayloadVie
 			}
 
 			if _, err := regexp.Compile(delay.UrlPattern); err != nil {
-				return errors.New(fmt.Sprintf("Response delay entry skipped due to invalid pattern : %s", delay.UrlPattern))
+				return fmt.Errorf("Response delay entry skipped due to invalid pattern : %s", delay.UrlPattern)
 			}
 
 			if err := coreDelay.ValidateLogNormalDelayOptions(delay.Min, delay.Max, delay.Mean, delay.Median); err != nil {

hoverctl/wrapper/hoverfly.go

@@ -188,7 +188,7 @@ func Start(target *configuration.Target) error {
 			if err != nil {
 				log.Debug(err)
 			}
-			return errors.New(fmt.Sprintf("Timed out waiting for Hoverfly to become healthy, returns status: %v", statusCode))
+			return fmt.Errorf("Timed out waiting for Hoverfly to become healthy, returns status: %v", statusCode)
 		case <-tick:
 			resp, err := http.Get(fmt.Sprintf("http://localhost:%v/api/health", target.AdminPort))
 			if err == nil {