Use io:: prefix for IO structs and traits

ext/crates/algebra/src/algebra/pair_algebra.rs

@@ -17,7 +17,7 @@ use crate::{combinatorics, Algebra};
 
 type HashMap<K, V> = hashbrown::HashMap<K, V, std::hash::BuildHasherDefault<FxHasher>>;
 
-use std::io::{Read, Write};
+use std::io;
 
 /// A lift of an algebra to a split pair algebra. See module introduction for more.
 pub trait PairAlgebra: Algebra {
@@ -82,13 +82,12 @@ pub trait PairAlgebra: Algebra {
     /// indecomposable.
     fn p_tilde(&self) -> usize;
 
-    fn element_to_bytes(&self, elt: &Self::Element, buffer: &mut impl Write)
-        -> std::io::Result<()>;
+    fn element_to_bytes(&self, elt: &Self::Element, buffer: &mut impl io::Write) -> io::Result<()>;
     fn element_from_bytes(
         &self,
         degree: i32,
-        buffer: &mut impl Read,
-    ) -> std::io::Result<Self::Element>;
+        buffer: &mut impl io::Read,
+    ) -> io::Result<Self::Element>;
 }
 
 use std::cell::RefCell;
@@ -299,11 +298,7 @@ impl PairAlgebra for MilnorAlgebra {
         }
     }
 
-    fn element_to_bytes(
-        &self,
-        elt: &Self::Element,
-        buffer: &mut impl Write,
-    ) -> std::io::Result<()> {
+    fn element_to_bytes(&self, elt: &Self::Element, buffer: &mut impl io::Write) -> io::Result<()> {
         elt.twos.to_bytes(buffer)?;
         for row in &elt.ys {
             for v in row {
@@ -316,8 +311,8 @@ impl PairAlgebra for MilnorAlgebra {
     fn element_from_bytes(
         &self,
         degree: i32,
-        buffer: &mut impl Read,
-    ) -> std::io::Result<Self::Element> {
+        buffer: &mut impl io::Read,
+    ) -> io::Result<Self::Element> {
         let p = self.prime();
         assert_eq!(p, TWO);
 

ext/crates/algebra/src/algebra/steenrod_algebra.rs

@@ -1,4 +1,4 @@
-use std::io::{Read, Write};
+use std::io;
 
 use anyhow::anyhow;
 use fp::{
@@ -263,16 +263,16 @@ impl crate::pair_algebra::PairAlgebra for AdemAlgebra {
     fn element_to_bytes(
         &self,
         _elt: &Self::Element,
-        _buffer: &mut impl Write,
-    ) -> std::io::Result<()> {
+        _buffer: &mut impl io::Write,
+    ) -> io::Result<()> {
         unimplemented!()
     }
 
     fn element_from_bytes(
         &self,
         _degree: i32,
-        _buffer: &mut impl Read,
-    ) -> std::io::Result<Self::Element> {
+        _buffer: &mut impl io::Read,
+    ) -> io::Result<Self::Element> {
         unimplemented!()
     }
 }
@@ -286,8 +286,8 @@ impl crate::pair_algebra::PairAlgebra for SteenrodAlgebra {
         fn sigma_multiply_basis(&self, result: &mut Self::Element, coeff: u32, r_degree: i32, r_idx: usize, s_degree: i32, s_idx: usize);
         fn sigma_multiply(&self, result: &mut Self::Element, coeff: u32, r_degree: i32, r: FpSlice, s_degree: i32, s: FpSlice);
         fn a_multiply(&self, result: FpSliceMut, coeff: u32, r_degree: i32, r: FpSlice, s_degree: i32, s: &Self::Element);
-        fn element_to_bytes(&self, elt: &Self::Element, buffer: &mut impl Write) -> std::io::Result<()>;
-        fn element_from_bytes(&self, degree: i32, buffer: &mut impl Read) -> std::io::Result<Self::Element>;
+        fn element_to_bytes(&self, elt: &Self::Element, buffer: &mut impl io::Write) -> io::Result<()>;
+        fn element_from_bytes(&self, degree: i32, buffer: &mut impl io::Read) -> io::Result<Self::Element>;
     }
 
     fn element_is_zero(elt: &Self::Element) -> bool {

ext/crates/chart/src/lib.rs

@@ -1,6 +1,6 @@
 #![deny(clippy::use_self)]
 
-use std::{collections::HashMap, fmt::Display, io::Write};
+use std::{collections::HashMap, fmt::Display, io};
 
 #[rustfmt::skip]
 const PATTERNS: [(f32, &[(f32, f32)]); 12] = [
@@ -105,14 +105,14 @@ pub trait Backend {
     }
 }
 
-pub struct SvgBackend<T: Write> {
+pub struct SvgBackend<T: io::Write> {
     out: T,
     max_x: i32,
     max_y: i32,
     num_nodes: HashMap<(i32, i32), usize>,
 }
 
-impl<T: Write> SvgBackend<T> {
+impl<T: io::Write> SvgBackend<T> {
     const GRID_WIDTH: i32 = 20;
     const MARGIN: i32 = 30;
     const STYLES: &'static str = r#"
@@ -200,8 +200,8 @@ impl<T: Write> SvgBackend<T> {
     }
 }
 
-impl<T: Write> Backend for SvgBackend<T> {
-    type Error = std::io::Error;
+impl<T: io::Write> Backend for SvgBackend<T> {
+    type Error = io::Error;
 
     const EXT: &'static str = "svg";
 
@@ -304,20 +304,20 @@ impl<T: Write> Backend for SvgBackend<T> {
     }
 }
 
-impl<T: Write> Drop for SvgBackend<T> {
+impl<T: io::Write> Drop for SvgBackend<T> {
     fn drop(&mut self) {
         writeln!(self.out, "</svg>").unwrap();
     }
 }
 
-pub struct TikzBackend<T: Write> {
+pub struct TikzBackend<T: io::Write> {
     out: T,
     max_x: i32,
     max_y: i32,
     num_nodes: HashMap<(i32, i32), usize>,
 }
 
-impl<T: Write> TikzBackend<T> {
+impl<T: io::Write> TikzBackend<T> {
     const HEADER: &'static str = r"\begin{tikzpicture}[
   major-grid/.style={ opacity = 0.2 },
   grid/.style={ opacity = 0.1 },
@@ -350,7 +350,7 @@ impl<T: Write> TikzBackend<T> {
     }
 }
 
-impl<T: Write> Backend for TikzBackend<T> {
+impl<T: io::Write> Backend for TikzBackend<T> {
     type Error = std::io::Error;
 
     const EXT: &'static str = "tex";
@@ -432,7 +432,7 @@ impl<T: Write> Backend for TikzBackend<T> {
     }
 }
 
-impl<T: Write> Drop for TikzBackend<T> {
+impl<T: io::Write> Drop for TikzBackend<T> {
     fn drop(&mut self) {
         writeln!(self.out, r#"\end{{tikzpicture}}"#).unwrap();
     }

ext/crates/fp/build.rs

@@ -1,10 +1,10 @@
-use std::io::Error;
+use std::io;
 
 use build_const::ConstWriter;
 
 type Limb = u64;
 
-fn main() -> Result<(), Error> {
+fn main() -> io::Result<()> {
     // We want primes up to 2^8 - 1, because those will be the characteristics of the fields that
     // have degree at least 2 and order at most 2^16 - 1. We will use PRIME_TO_INDEX_MAP when
     // computing Zech logarithms.

ext/crates/fp/src/matrix/matrix_inner.rs

@@ -1,6 +1,5 @@
 use std::{
-    fmt,
-    io::{Read, Write},
+    fmt, io,
     ops::{Index, IndexMut},
 };
 
@@ -83,8 +82,8 @@ impl Matrix {
         p: ValidPrime,
         rows: usize,
         columns: usize,
-        data: &mut impl Read,
-    ) -> std::io::Result<Self> {
+        data: &mut impl io::Read,
+    ) -> io::Result<Self> {
         let mut vectors: Vec<FpVector> = Vec::with_capacity(rows);
         for _ in 0..rows {
             vectors.push(FpVector::from_bytes(p, columns, data)?);
@@ -97,15 +96,15 @@ impl Matrix {
         })
     }
 
-    pub fn to_bytes(&self, data: &mut impl Write) -> std::io::Result<()> {
+    pub fn to_bytes(&self, data: &mut impl io::Write) -> io::Result<()> {
         for v in &self.vectors {
             v.to_bytes(data)?;
         }
         Ok(())
     }
 
     /// Read a vector of `isize`
-    pub(crate) fn write_pivot(v: &[isize], buffer: &mut impl Write) -> std::io::Result<()> {
+    pub(crate) fn write_pivot(v: &[isize], buffer: &mut impl io::Write) -> io::Result<()> {
         if cfg!(all(target_endian = "little", target_pointer_width = "64")) {
             unsafe {
                 let buf: &[u8] = std::slice::from_raw_parts(v.as_ptr() as *const u8, v.len() * 8);
@@ -121,7 +120,7 @@ impl Matrix {
     }
 
     /// Read a vector of `isize` of length `dim`.
-    pub(crate) fn read_pivot(dim: usize, data: &mut impl Read) -> std::io::Result<Vec<isize>> {
+    pub(crate) fn read_pivot(dim: usize, data: &mut impl io::Read) -> io::Result<Vec<isize>> {
         if cfg!(all(target_endian = "little", target_pointer_width = "64")) {
             let mut image = vec![0; dim];
             unsafe {

ext/crates/fp/src/matrix/quasi_inverse.rs

@@ -1,4 +1,4 @@
-use std::io::{Read, Write};
+use std::io;
 
 use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
 use itertools::Itertools;
@@ -43,7 +43,7 @@ impl QuasiInverse {
         }
     }
 
-    pub fn to_bytes(&self, buffer: &mut impl Write) -> std::io::Result<()> {
+    pub fn to_bytes(&self, buffer: &mut impl io::Write) -> io::Result<()> {
         buffer.write_u64::<LittleEndian>(self.source_dimension() as u64)?;
         buffer.write_u64::<LittleEndian>(self.target_dimension() as u64)?;
         buffer.write_u64::<LittleEndian>(self.image_dimension() as u64)?;
@@ -61,7 +61,7 @@ impl QuasiInverse {
         self.preimage.to_bytes(buffer)
     }
 
-    pub fn from_bytes(p: ValidPrime, data: &mut impl Read) -> std::io::Result<Self> {
+    pub fn from_bytes(p: ValidPrime, data: &mut impl io::Read) -> io::Result<Self> {
         let source_dim = data.read_u64::<LittleEndian>()? as usize;
         let target_dim = data.read_u64::<LittleEndian>()? as usize;
         let image_dim = data.read_u64::<LittleEndian>()? as usize;
@@ -79,10 +79,10 @@ impl QuasiInverse {
     /// quasi-inverse row by row to minimize memory usage.
     pub fn stream_quasi_inverse<T, S>(
         p: ValidPrime,
-        data: &mut impl Read,
+        data: &mut impl io::Read,
         results: &mut [T],
         inputs: &[S],
-    ) -> std::io::Result<()>
+    ) -> io::Result<()>
     where
         for<'a> &'a mut T: Into<FpSliceMut<'a>>,
         for<'a> &'a S: Into<FpSlice<'a>>,
@@ -173,7 +173,7 @@ mod tests {
         let mut out0 = FpVector::new(p, 4);
         let mut out1 = FpVector::new(p, 4);
 
-        let mut cursor = std::io::Cursor::new(Vec::<u8>::new());
+        let mut cursor = io::Cursor::new(Vec::<u8>::new());
         qi.to_bytes(&mut cursor).unwrap();
         cursor.set_position(0);
 

ext/crates/fp/src/matrix/subspace.rs

@@ -1,7 +1,4 @@
-use std::{
-    io::{Read, Write},
-    ops::Deref,
-};
+use std::{io, ops::Deref};
 
 use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
 use itertools::Itertools;
@@ -60,7 +57,7 @@ impl Subspace {
         ret
     }
 
-    pub fn from_bytes(p: ValidPrime, data: &mut impl Read) -> std::io::Result<Self> {
+    pub fn from_bytes(p: ValidPrime, data: &mut impl io::Read) -> io::Result<Self> {
         let rows = data.read_u64::<LittleEndian>()? as usize;
         let ambient_dimension = data.read_u64::<LittleEndian>()? as usize;
 
@@ -71,7 +68,7 @@ impl Subspace {
         Ok(Self { matrix })
     }
 
-    pub fn to_bytes(&self, buffer: &mut impl Write) -> std::io::Result<()> {
+    pub fn to_bytes(&self, buffer: &mut impl io::Write) -> io::Result<()> {
         buffer.write_u64::<LittleEndian>(self.matrix.rows() as u64)?;
         buffer.write_u64::<LittleEndian>(self.ambient_dimension() as u64)?;
 

ext/crates/fp/src/vector/fp_wrapper/mod.rs

@@ -12,10 +12,7 @@
 //! we can't simply define `type FpVector = FqVector<Fp<2>>` like we previously did: we need to use
 //! a transparent wrapper.
 
-use std::{
-    convert::TryInto,
-    io::{Read, Write},
-};
+use std::{convert::TryInto, io};
 
 use itertools::Itertools;
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
@@ -104,9 +101,9 @@ impl FpVector {
         pub fn new<P: Prime>(p: P, len: usize) -> (from FqVector);
         pub fn new_with_capacity<P: Prime>(p: P, len: usize, capacity: usize) -> (from FqVector);
 
-        pub fn update_from_bytes(&mut self, data: &mut impl Read) -> (std::io::Result<()>);
-        pub fn from_bytes<P: Prime>(p: P, len: usize, data: &mut impl Read) -> (from io FqVector);
-        pub fn to_bytes(&self, buffer: &mut impl Write) -> (std::io::Result<()>);
+        pub fn update_from_bytes(&mut self, data: &mut impl io::Read) -> (io::Result<()>);
+        pub fn from_bytes<P: Prime>(p: P, len: usize, data: &mut impl io::Read) -> (from io FqVector);
+        pub fn to_bytes(&self, buffer: &mut impl io::Write) -> (io::Result<()>);
     }
 
     pub fn from_slice<P: Prime>(p: P, slice: &[u32]) -> Self {

ext/examples/bruner.rs

@@ -19,7 +19,7 @@
 
 use std::{
     fs::File,
-    io::{BufRead, BufReader},
+    io,
     path::{Path, PathBuf},
     str::FromStr,
     sync::Arc,
@@ -47,7 +47,7 @@ type FreeModuleHomomorphism = FMH<FreeModule>;
 type FiniteChainComplex = FCC<FreeModule, FreeModuleHomomorphism>;
 
 /// Read the first non-empty line of `data` into `buf`. Returns whether a line is read
-fn read_line(data: &mut impl BufRead, buf: &mut String) -> Result<bool> {
+fn read_line(data: &mut impl io::BufRead, buf: &mut String) -> Result<bool> {
     buf.clear();
     while buf.is_empty() {
         let num_bytes = data.read_line(buf)?;
@@ -108,7 +108,7 @@ fn get_algebra_element<'a>(
 fn get_element(
     a: &MilnorAlgebra,
     m: &FreeModule,
-    input: &mut impl BufRead,
+    input: &mut impl io::BufRead,
 ) -> Result<Option<(i32, FpVector)>> {
     let mut buf = String::new();
     if !read_line(input, &mut buf)? {
@@ -188,7 +188,7 @@ fn read_bruner_resolution(data_dir: &Path, max_n: i32) -> Result<(u32, FiniteCha
         let m = cc.module(s);
         let d = cc.differential(s);
 
-        let mut f = BufReader::new(
+        let mut f = io::BufReader::new(
             File::open(data_dir.join(format!("hDiff.{s}")))
                 .with_context(|| format!("Failed to read hDiff.{s}"))?,
         );

ext/rustc-ice-2024-12-06T01_29_33-1201382.txt

@@ -0,0 +1,23 @@
+delayed bug: expansion entered force mode without producing any errors
+   0: <rustc_errors::DiagCtxtInner>::emit_diagnostic
+   1: <rustc_errors::DiagCtxtHandle>::emit_diagnostic
+   2: <rustc_span::ErrorGuaranteed as rustc_errors::diagnostic::EmissionGuarantee>::emit_producing_guarantee
+   3: <rustc_errors::DiagCtxtHandle>::span_delayed_bug::<rustc_span::span_encoding::Span, &str>
+   4: <rustc_expand::expand::MacroExpander>::fully_expand_fragment
+   5: <rustc_expand::expand::MacroExpander>::expand_crate
+   6: rustc_interface::passes::resolver_for_lowering_raw
+   7: rustc_query_impl::plumbing::__rust_begin_short_backtrace::<rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle::query::erase::Erased<[u8; 16]>>
+   8: <rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2} as core::ops::function::FnOnce<(rustc_middle::ty::context::TyCtxt, ())>>::call_once
+   9: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::DynamicConfig<rustc_query_system::query::caches::SingleCache<rustc_middle::query::erase::Erased<[u8; 16]>>, false, false, false>, rustc_query_impl::plumbing::QueryCtxt, false>
+  10: rustc_query_impl::query_impl::resolver_for_lowering_raw::get_query_non_incr::__rust_end_short_backtrace
+  11: rustc_interface::interface::run_compiler::<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}
+  12: std::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>
+  13: <<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
+  14: std::sys::pal::unix::thread::Thread::new::thread_start
+  15: start_thread
+  16: clone3
+
+
+
+rustc version: 1.85.0-nightly (dff3e7ccd 2024-11-26)
+platform: x86_64-unknown-linux-gnu