Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature gate for serde #141

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

JoeyBF
Copy link
Collaborator

@JoeyBF JoeyBF commented Nov 23, 2023

I'm not sure why they were there in the first place. The tests still pass if we just always implement Serialize/Deserialize

@JoeyBF JoeyBF mentioned this pull request Nov 23, 2023
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks @JoeyBF!

@JoeyBF JoeyBF merged commit aa6b8fe into SpectralSequences:master Nov 27, 2023
21 of 24 checks passed
@JoeyBF JoeyBF deleted the serde_no_gate branch November 27, 2023 16:54
github-actions bot added a commit that referenced this pull request Nov 27, 2023
* Remove `serde_json` gates

* Adjust `web_ext`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants