-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debian systemd service file. #168
base: master
Are you sure you want to change the base?
Improve debian systemd service file. #168
Conversation
Niluge-KiWi
commented
Oct 17, 2016
- better description and documentation
- use spectrum2 dedicated user
- restart on failure, without spamming other servers
- no need for a short TimeoutStopSec: spectrum2 supposedly correctly shuts down
- no need for Alias: the current filename is already OK
- add WantedBy=multi-user.target for install
* better description and documentation * use spectrum2 dedicated user * restart on failure, without spamming other servers * no need for a short TimeoutStopSec: spectrum2 supposedly correctly shuts down * no need for Alias: the current filename is already OK * add WantedBy=multi-user.target for install
This requires more packaging change such as user creation, various directories permissions for the new user, etc... |
Take a look at some examples: user creation and directories permissions |
I worked in the systemd service file because it's easy to develop and test But I won't work on trying to correctly build the .deb. It works enough on Le mer. 19 oct. 2016 10:55, vitalyster notifications@github.com a écrit :
|
I don't think the user should be specified in systemd service file, since you can specify users and groups in spectrum transports config files, which seems to work fine for me. If you want to get non-root user by default in the deb, the package should create system user and have the user/group entries in the example config files uncommented. Other stuff looks nice 👍 |
What's missing is systemd for the server (webserver) to register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Is @Niluge-KiWi still interested to merge this?
Or shall I create a new PR?
After=network.target | ||
|
||
[Service] | ||
Type=forking | ||
|
||
User=spectrum2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As proposed by others, I propose to drop this line for the sake of an easier setup and leave dropping the privileges to spectrum_manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using systemd-sysusers?