-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump compat to GPUArrays v11, JLArrays v0.1, KernelAbstractions 0.9 #658
base: main
Are you sure you want to change the base?
Conversation
@jackleland @maximilian-gelbrecht I believe we can now upgrade GPUArrays, JLArrays, and KernelAbstractions compat. One would (fingers crossed) roll forward these two changes again SpeedyWeather.jl/src/RingGrids/general.jl Lines 485 to 489 in f90b9d8
SpeedyWeather.jl/src/LowerTriangularMatrices/lower_triangular_array.jl Lines 633 to 637 in 719dce9
that #636 rolled back |
Tests are passing here. I'd like to briefly test on GPU before merging as well. |
Ah, the tests are passing here, but I think the compat entries are actually wrong, we do loose compatibility with GPUArrays v10. It'll be only compatible with v11. |
riiiight, is there a reason why we wouldn't upgrade then? E.g. I guess this means that older CUDA jl versions don't support v11, does that restrict us in any other way? |
I mean it's only relevant if someone wants to use Speedy with some package that isn't updated yet to be compatible with GPUArrays v11. Not sure if there are many around. This is only relevant for packages that do something with GPUs. Even if that's the case, they'd still just get a slightly older version of Speedy. |
Oceananigans still uses GPUArrays v10, so at the moment that would disallow running both simultaneously (coupling), but I believe by the time we do GPU-GPU coupling they will have upgraded already (@simone-silvestri do you plan to change compat to GPUArrays v11?). And it's better to go to the new version anyway. Green light from my side! |
There has been a feature removal in |
We are in no hurry with this. I think we can wait until Oceananigans is compatible as well. |
Because even if we run CPU-GPU with Oceananigans this will create a compat conflict? Yes makes sense |
No description provided.