-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typos #489
Correct typos #489
Conversation
This corrects several typographical errors as well as an incorrect URL in README.md.
Looks like we were both working on the same files at the same time x_x |
No worries. I'm out of the lab at the moment but as soon as I get back I'll resolve the conflicts. |
New fixes to account for new changes to master.
Corrected typos in PWMTest and added it to the list of examples to compile against when checking pushes/PRs.
Okay, this should do it. Fixed a ton of errors in the PWMTest example so that it will actually compile, and added it to the list of examples to check against for pushes/PRs. While I did test it on DB just to make sure it compiles and flashes, I did not test on-hardware to make sure that the program actually did what it purports to do. My lab setup isn't really configured for that sort of thing at the moment. |
Whoops, PWMTest requires millis to not be disabled
Created new special category just for PWMTest since it requires both millis and PROGMEM_MAPPED to be enabled in order to compile.
Thanks I just can't seem to make even the slightest change to code without fucking up the semicolons and braces can I.... The code was 100% working before I renamed the file and cleaned up the comments, and apparently trashed numerous other parts of the file. It's of dubious value as a compile test - I don't know it can access any code code paths not otherwise tested. What it will do on hardware is test that PWM comes out of all the pins it's supposed to, tel you how many cycles it saw in a second, and treat anything outside of our guidelines as a failure (480-1920 or something like that - below that andvisible flicker and technicholor trails result if you pwm LEDs, above that and you may need to use a MOSFET driver to PWM a MOSFET gate), it will work if you set TCAROUTEA or TCDROUTEA at the top of setup (TCD mux only avail if you are on a DD, TCD portmux is errata'ed on DB/DA), and that PWM stops coming out when we turn it off, and that the DAC turns on and off. After testing the TCAs, it calls takeOverTCA0, takeOverTCA1 because some of the TCB pins are underneath the TCA pins. and then reenables the timers with the same CTRLA as it had before, so that the TCBs will have a clock to use (but by calling the takeover, the core no longer intercepts analogWrite pointed at that timer, so the logic falls through tothe next rung in analogWrite where it checks for other timers on the pin. It would be an awesome test if I had automatic testing on hardware. Most importantly - it does not require any hardware connections except for the serial port, and UPDI (unless using optiboot) |
This corrects several typographical errors as well as an incorrect URL in README.md leading to the $50 contest details.