Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple new features #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ste-art
Copy link

@ste-art ste-art commented Apr 13, 2024

This should be several different PRs, but I got a little carried away, so here all the changes.

Features

  • /preset command that applyes settings presets specified in config.json. Quite useful for swithing between SDXL and Lightning models that requires specific cfg_scale, steps and sampler. Also, it could be used for quick apply square/portrait/album image size.
  • Support FreeU and Self Attention Guidance, available in Forge-UI. /freeu and /sag commands for configuration. This feature only enabled if webui supports FreeU and SAG. If not - commands will not be added.
  • Added max load check to prevent huge requests like 2048x2048 x 100 steps x 4 images. Default limit is 65536 that equals to a single image 1024x1024 x 256 steps, or 2048x2048 x 64 steps, or 4 images 1024x1024 x 64 steps.

Small changes

  • Option filter now case-insensetive.
  • Added n_iter and seed values to the /settings command.

Bug fixes

  • The bot no longer recreates /lora-list and /cluster_status command on each lauch. Caused by extra space symbol in the description.
  • The bot no longer recreates commands that have options with minimum values. Caused by comparing pointer addresses instead of actual values.
  • It's no longer possible to set unlimited width, height and steps using /settings command. Also, all option constraints in /settings, /txt2imgand/img2img` are unified.
  • Fixed option filter - options no longer disappear when a filter tries to return more than 25 items.

Internal changes

  • Replaced DefaultSetting with StableConfig. They are grow bigger and it odd to have both of them with the same exact settings.

@ste-art ste-art changed the title Dev ste art Multiple new features Apr 13, 2024
@Eidenz
Copy link

Eidenz commented Jul 25, 2024

This PR is broken currently:

2024/07/25 10:02:04 Adding/Updating commands...
2024/07/25 10:02:04 Cannot create 'txt2img' command: HTTP 400 Bad Request, {"message": "Invalid Form Body", "code": 50035, "errors": {"options": {"1": {"description": {"_errors": [{"code": "BASE_TYPE_BAD_LENGTH", "message": "Must be between 1 and 100 in length."}]}}}}}
panic: Cannot create 'txt2img' command: HTTP 400 Bad Request, {"message": "Invalid Form Body", "code": 50035, "errors": {"options": {"1": {"description": {"_errors": [{"code": "BASE_TYPE_BAD_LENGTH", "message": "Must be between 1 and 100 in length."}]}}}}}

goroutine 1 [running]:
log.Panicf({0xed8dbb?, 0x7?}, {0xc000049d18?, 0x0?, 0x0?})
        /usr/lib/go-1.22/src/log/log.go:439 +0x65
github.com/SpenserCai/sd-webui-discord/dbot.(*DiscordBot).SyncCommands(0xc000482050)
        /home/eidenz/sdwebuidiscord/dbot/handler.go:96 +0x565
github.com/SpenserCai/sd-webui-discord/dbot.(*DiscordBot).Run(0xc000482050)
        /home/eidenz/sdwebuidiscord/dbot/dbot.go:63 +0xc9
main.main()
        /home/eidenz/sdwebuidiscord/main.go:163 +0x458

I just pulled, built and tested. This is what I get when I have some default settings in config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants