feature/SDK-39_well-known-oidf #164

sanderPostma · 2024-10-29T20:35:53Z

No description provided.

…8414-auth-server-metadata

codecov · 2024-10-29T20:38:40Z

Codecov Report

Attention: Patch coverage is 29.48718% with 110 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (86f6d4a) to head (42688c6).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../lib/builder/AuthorizationServerMetadataBuilder.ts	21.60%	98 Missing ⚠️
packages/issuer/lib/builder/VcIssuerBuilder.ts	61.53%	5 Missing ⚠️
packages/issuer/lib/VcIssuer.ts	33.33%	4 Missing ⚠️
packages/issuer-rest/lib/oid4vci-api-functions.ts	72.72%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
- Coverage    49.11%   48.46%   -0.65%     
===========================================
  Files           74       75       +1     
  Lines         4976     5127     +151     
  Branches      1769     1774       +5     
===========================================
+ Hits          2444     2485      +41     
- Misses        2529     2639     +110     
  Partials         3        3

Flag	Coverage Δ
unittest	`48.46% <29.48%> (-0.65%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nklomp

1 Please be more careful with your imports. Mulltiple of them are off
2 OIDF has nothing todo with OID4VC, except for the fact it can be used as a registry for trust establishment. So it for sure does not belong in the VCI REST API or anything

nklomp · 2024-10-30T01:18:12Z

packages/callback-example/lib/__tests__/issuerCallback.spec.ts

@@ -24,6 +24,9 @@ import { DIDDocument } from 'did-resolver'
 import * as jose from 'jose'

 import { generateDid, getIssuerCallbackV1_0_11, getIssuerCallbackV1_0_13, verifyCredential } from '../IssuerCallback'
+import {
+  AuthorizationServerMetadataBuilder
+} from '@sphereon/oid4vci-issuer/dist/builder/AuthorizationServerMetadataBuilder'


Incorrect import

nklomp · 2024-10-30T01:18:42Z

packages/issuer-rest/lib/__tests__/ClientIssuerIT.spec.ts

 } from '@sphereon/oid4vci-common'
 import { VcIssuer } from '@sphereon/oid4vci-issuer/dist/VcIssuer'
 import { CredentialSupportedBuilderV1_13, VcIssuerBuilder } from '@sphereon/oid4vci-issuer/dist/builder'
+import {
+  AuthorizationServerMetadataBuilder
+} from '@sphereon/oid4vci-issuer/dist/builder/AuthorizationServerMetadataBuilder'


Import error

nklomp · 2024-10-30T01:19:07Z

packages/issuer-rest/lib/__tests__/IssuerTokenServer.spec.ts

@@ -12,6 +12,9 @@ import {
  URIState,
 } from '@sphereon/oid4vci-common'
 import { VcIssuer } from '@sphereon/oid4vci-issuer'
+import {
+  AuthorizationServerMetadataBuilder
+} from '@sphereon/oid4vci-issuer/dist/builder/AuthorizationServerMetadataBuilder'


Import error.

nklomp · 2024-10-30T01:20:20Z

packages/issuer-rest/lib/oid4vci-api-functions.ts

+  }
+  router.get(WellKnownEndpoints.OAUTH_AS, authorizationServerHandler)
+
+  const openidFederationHandler = (request: Request, response: Response) => {


Why is a REST API implementation of a OID4VC protocol which has little relation to OIDF all of a sudden handling OIDF metadata and wellknowns?

@nklomp
The requested task was to host https://agent.wallet.bd.demo.sphereon.com/oid4vci/.well-known/openid-federation. Since the path was /oid4vci/* I assumed it was part of the issuer logic.
Plus it's already hosting /.well-known/openid-credential-issuer and /.well-known/oauth-authorization-server there, so it was the easiest place to do it.
Shall I create a separate oidf-metadata or something module for this in ssi-sdk?

nklomp · 2024-10-30T01:21:23Z

packages/issuer/lib/VcIssuer.ts

 } from '@sphereon/oid4vci-common'
 import { CredentialEventNames, CredentialOfferEventNames, EVENTS } from '@sphereon/oid4vci-common'
 import { CredentialIssuerMetadataOptsV1_0_13 } from '@sphereon/oid4vci-common'
+import { OpenidFederationMetadata } from '@sphereon/oid4vci-common/dist/types/OpenidFederationMetadata'


Please be more careful with your imports. There are multiple occasions I have to point out

fixed, but going to be removed

nklomp · 2024-10-30T01:21:34Z

packages/issuer/lib/VcIssuer.ts

@@ -45,6 +46,8 @@ import { CredentialDataSupplier, CredentialDataSupplierArgs, CredentialIssuanceI

 export class VcIssuer<DIDDoc extends object> {
  private readonly _issuerMetadata: CredentialIssuerMetadataOptsV1_0_13
+  private readonly _authorizationServerMetadata: AuthorizationServerMetadata
+  private readonly _openidFederationMetadata?: OpenidFederationMetadata


Should not be here

nklomp · 2024-10-30T01:22:12Z

packages/issuer/lib/builder/VcIssuerBuilder.ts

 } from '@sphereon/oid4vci-common'
-import { CredentialIssuerMetadataOptsV1_0_13 } from '@sphereon/oid4vci-common'
+import { OpenidFederationMetadata } from '@sphereon/oid4vci-common/dist/types/OpenidFederationMetadata'


Imports again!

fixed, but going to be removed

nklomp · 2024-10-30T01:22:27Z

packages/issuer/lib/builder/VcIssuerBuilder.ts

@@ -22,6 +24,8 @@ import { IssuerMetadataBuilderV1_13 } from './IssuerMetadataBuilderV1_13'
 export class VcIssuerBuilder<DIDDoc extends object> {
  issuerMetadataBuilder?: IssuerMetadataBuilderV1_13
  issuerMetadata: Partial<CredentialIssuerMetadataOptsV1_0_13> = {}
+  authorizationServerMetadata: Partial<AuthorizationServerMetadata> = {}
+  openidFederationMetadata: Partial<OpenidFederationMetadata> = {} 


Should not be here

sanderPostma · 2024-10-30T10:24:44Z

I wasn't done yet and also I did not review myself yet. I created a draft PR in IJ, but apparently it created a regular one.

sanderPostma added 8 commits October 22, 2024 18:19

chore: SDK-38 AuthorizationServerMetadata support

30235e0

chore: SDK-38 update tests

0af330d

chore: SDK-38 update tests

10e7492

Merge remote-tracking branch 'origin/develop' into feature/sdk-38_rfc…

30111d3

…8414-auth-server-metadata

chore: Added type for OpenidFederationMetadata

ab42e12

chore: OpenidFederationMetadata structures

75ff089

chore: fix export

7d37afb

chore: expose oidf endpoint

529e727

sanderPostma marked this pull request as ready for review October 29, 2024 20:35

sanderPostma added 2 commits October 29, 2024 21:52

chore: send openidFederationMetadata.jwt as payload

5ad6b02

chore: send openidFederationMetadata.jwt as payload

86e798c

nklomp requested changes Oct 30, 2024

View reviewed changes

chore: cleanup

98e3a6a

chore: import fixes

42688c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/SDK-39_well-known-oidf #164

feature/SDK-39_well-known-oidf #164

sanderPostma commented Oct 29, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading

nklomp left a comment

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma Oct 30, 2024

nklomp Oct 30, 2024

sanderPostma commented Oct 30, 2024

feature/SDK-39_well-known-oidf #164

Are you sure you want to change the base?

feature/SDK-39_well-known-oidf #164

Conversation

sanderPostma commented Oct 29, 2024

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

nklomp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanderPostma commented Oct 30, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading