-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some item props functionnality #1131
Conversation
2)Take a look at the Spell_Area method, anyway this area damage properties should call onTakeDamage, don't make a new method onTakeDamageArea |
5caa2cf
to
53f60e9
Compare
@drk84 I don't figure how avoid a new method for Takedamagearea... Yes I use takeDamage on the new method. What you think of this commit? |
Did you figure out the last prop you were working on? Is it still a draft? |
Ready to merge. I fixed the "criminal act check" |
Could you please fix the conflicts, in order to merge? |
I have 3 bug on this version.
1- (EDIT: FIXED)
Line
(pCharTarg->GetPropNum(pCCPChar, PROPCH_REFLECTPHYSICALDAM, pBaseCCPChar))
always return 0... I set REFLECTPHYSICALDAM on target but dont know why always 0
2- (EDIT: I added LOS and range 5 to 10 depending of ERA)
is the damage area function. I copy pasted from 56d but after testing it it's just fucking non sense.
I hit everyone on the BIG screen including NPC,PET inside or outside house lol
3- (EDIT: I choose 3 type of damage link to physical)
How I can use only physical damage on iDmg ?