Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some item props functionnality #1131

Merged
merged 24 commits into from
Mar 14, 2024
Merged

Conversation

Jhobean
Copy link
Contributor

@Jhobean Jhobean commented Oct 15, 2023

I have 3 bug on this version.

1- (EDIT: FIXED)
Line
(pCharTarg->GetPropNum(pCCPChar, PROPCH_REFLECTPHYSICALDAM, pBaseCCPChar))
always return 0... I set REFLECTPHYSICALDAM on target but dont know why always 0

2- (EDIT: I added LOS and range 5 to 10 depending of ERA)
is the damage area function. I copy pasted from 56d but after testing it it's just fucking non sense.
I hit everyone on the BIG screen including NPC,PET inside or outside house lol

3- (EDIT: I choose 3 type of damage link to physical)
How I can use only physical damage on iDmg ?

@Jhobean Jhobean marked this pull request as draft October 15, 2023 03:11
@drk84
Copy link
Member

drk84 commented Oct 15, 2023

2)Take a look at the Spell_Area method, anyway this area damage properties should call onTakeDamage, don't make a new method onTakeDamageArea
3)The damage applied is based upon the utype flag

@Jhobean Jhobean force-pushed the itemprop branch 3 times, most recently from 5caa2cf to 53f60e9 Compare October 15, 2023 13:13
@Jhobean Jhobean marked this pull request as ready for review October 16, 2023 00:18
@Jhobean
Copy link
Contributor Author

Jhobean commented Oct 16, 2023

Seem OK on my side.
The only thing i'm not sure is the Area damage hitting everyone.

Should I remove own pet?
Should I remove all criminal action? How?

image

@Jhobean
Copy link
Contributor Author

Jhobean commented Oct 16, 2023

@drk84 I don't figure how avoid a new method for Takedamagearea...

Yes I use takeDamage on the new method.

What you think of this commit?

@Jhobean Jhobean marked this pull request as draft October 17, 2023 11:15
@Jhobean Jhobean marked this pull request as ready for review October 17, 2023 23:16
@Jhobean Jhobean marked this pull request as draft November 4, 2023 02:03
@Jhobean Jhobean marked this pull request as ready for review November 10, 2023 18:10
@cbnolok
Copy link
Contributor

cbnolok commented Nov 17, 2023

Did you figure out the last prop you were working on? Is it still a draft?

@Jhobean
Copy link
Contributor Author

Jhobean commented Nov 17, 2023

Did you figure out the last prop you were working on? Is it still a draft?

Ready to merge. I fixed the "criminal act check"
if (pChar->Noto_CalcFlag(pSrc) == NOTO_GOOD)

@Jhobean Jhobean marked this pull request as draft December 11, 2023 12:45
@Jhobean Jhobean marked this pull request as ready for review December 11, 2023 12:54
@cbnolok
Copy link
Contributor

cbnolok commented Mar 13, 2024

Could you please fix the conflicts, in order to merge?

@cbnolok cbnolok merged commit 4934125 into Sphereserver:master Mar 14, 2024
7 checks passed
@Jhobean Jhobean deleted the itemprop branch March 14, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants