Followerslots with EF_FollowerList - FIX #1251 #1252
Conversation
while using EF_FollowerList Sphereserver#1251
| { | ||
| for (short i = 0; i < iFollowerSlots; ++i) | ||
| { | ||
| m_followers.emplace_back(pChar->GetUID()); |
There was a problem hiding this comment.
We could do that better, by making m_followers a vector of std::pair<ushort, CUID>, where the first number is the followerslots, value the second the UID.
There was a problem hiding this comment.
I can try, but I think Im not capable of doing that. Wouldnt that need more complex changes in the whole code?
There was a problem hiding this comment.
I suppose its defined as CUID already
std::vector<CUID> m_followers; which means we would have to review every code where is it used? If we change it to std::vector<std::pair<ushort, CUID>> m_followers; ?
There was a problem hiding this comment.
Im sorry im not able to do that, I guess if we change the def of the vector, we need to change every part where the FollowersUpdate is called/used, and even with the AI help, I couldnt make it work. 😥
Anyone ideas or more experience?
There was a problem hiding this comment.
I will take care of it, we'll need to change other code to make it working but it will be worth it.
Fix for the review
Tested on local and seems good.
Issue:
#1251