-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One dict #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we still want the one dict? |
rowleya
reviewed
Mar 29, 2022
rowleya
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK - just a couple of minor comments elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Places the numbers for log messages in a single dict file.
If you rerun part of the later makes it just uses new numbers and makes the file bigger but still works.
If you rebuild FrontEndcommon it will nuke the file and everything upstream MUST be built over new.
MUST be done at the same time as SpiNNakerManchester/SpiNNFrontEndCommon#567
tested by SpiNNakerManchester/IntegrationTests#7
==
By default the dictionary is stored at spinn_utilities/make_tools/logs.sqlite3
It will need to be added in the same way the aplx files are for a release.
The location can be changed by environment variable C_LOGS_DICT
Automatatic make will clear the previous dictionary.
log_id numbers are only changed if the log call changes signature or position.
TestConverter test test_convert demonstrates this.
Replace now also works from the command line as
python -m spinn_utilities.make_tools.replacer
This can either be called with a single log_id to give the original line
or with the whole short log. Note then any non alphabet, non number character works as the token