Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One dict #114

Merged
merged 56 commits into from
Mar 31, 2022
Merged

One dict #114

merged 56 commits into from
Mar 31, 2022

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Mar 16, 2020

Places the numbers for log messages in a single dict file.

If you rerun part of the later makes it just uses new numbers and makes the file bigger but still works.

If you rebuild FrontEndcommon it will nuke the file and everything upstream MUST be built over new.

MUST be done at the same time as SpiNNakerManchester/SpiNNFrontEndCommon#567

tested by SpiNNakerManchester/IntegrationTests#7

==

By default the dictionary is stored at spinn_utilities/make_tools/logs.sqlite3
It will need to be added in the same way the aplx files are for a release.
The location can be changed by environment variable C_LOGS_DICT

Automatatic make will clear the previous dictionary.

log_id numbers are only changed if the log call changes signature or position.
TestConverter test test_convert demonstrates this.

Replace now also works from the command line as
python -m spinn_utilities.make_tools.replacer
This can either be called with a single log_id to give the original line
or with the whole short log. Note then any non alphabet, non number character works as the token

@Christian-B
Copy link
Member Author

Do we still want the one dict?

Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK - just a couple of minor comments elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants