This repository has been archived by the owner on May 14, 2020. It is now read-only.
Ensure Docker image can be built #1432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutter
changed the title
|
Ah, I edited in some new issues, working on it... |
The tag in owasp/modsecurity has been renamed, this commit updates the Dockerfile accordingly. However, since the directory structure has also been update in the upstream image (/etc/apache2/modsecurity.d has been moved to /etc/modsecurity.d), some more changes to the Dockerfile were necessary Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
changed the title
|
Thanks, i'll be taking a look at this today. |
|
couple issues here -- with where files are being put, I am going to open a PR for this that basis it off the v3.2 image |
|
If you want, Chaim, we can take a look at what it would take to build a production-grade container image. This would be an image that:
|
|
moving modsec-docker to multi stage builds will go a LONG way to solving the first two. Honestly, until OWASP solves the dockerhub issue, I think this is where we should spend our energy :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a minimal PR to ensure the 3.1 branch can at least be built. This should help with #1420.
I know you're working on the 3.2 branch, but the 3.1 Tag on Docker Hub is horribly out of date and contains a lot of critical CVEs, which is kind of bad of r a security-related project.
Changes: